Fix files only covered by one LCOV report showing 100% coverage #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
neat! Thanks! @matsjoyce-refeyn can you add a test? |
|
@Bachmann1234 Done, I took the tests from one of the XML reporters and converted it to LCOV format. The |
|
@Bachmann1234 Is there anything else you need for this PR to get merged? |
No, sorry! I'll merge this now and release this week |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our CI pipeline we are using pytest (+pytest-cov) to generate coverage for Python files, and cargo-llvm-cov to generate coverage for Rust files. Both tools can generate LCOV files, which we then pass to diff-cover. Since each tool only covers one language, the LCOV files do not overlap - a given file will only be present in one file or the other. This causes issues as diff-cover then reports 100% coverage for every file.
The root cause is that currently diff-cover always tries to find uncovered lines for each file in each report, and so if the file is not present in that report, the file is assumed to have no uncovered lines. This PR fixes the behaviour by skipping reports that the file does not appear in. I believe that matches the behaviour of the XML report parsing code.