Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapshot class for matching eip712 specs and data structured #1006

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

petrovska-petro
Copy link
Collaborator

@petrovska-petro petrovska-petro commented Dec 7, 2022

Tackles #986

NOTE: hashes generation does not match between the class and the relayer endpoint

@petrovska-petro petrovska-petro marked this pull request as draft December 7, 2022 14:19
@gosuto-inzasheru gosuto-inzasheru changed the title Update snapshot class for matching eip7712 specs and data structured Update snapshot class for matching eip712 specs and data structured Dec 16, 2022
@gosuto-inzasheru
Copy link
Collaborator

discussed with @petrovska-petro; will be easier to help debug and review with a test case in tests/ which now fails but should pass.

@petrovska-petro petrovska-petro marked this pull request as ready for review January 10, 2023 14:39
@petrovska-petro
Copy link
Collaborator Author

discussed with @petrovska-petro; will be easier to help debug and review with a test case in tests/ which now fails but should pass.

push test in 6e80c8d

run:

brownie test tests/snapshot/test_eip712_hash.py -s 

@petrovska-petro petrovska-petro marked this pull request as draft January 10, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants