Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is Position's timestamp property nullable? #1145

Closed
jjoelson opened this issue Oct 3, 2022 · 3 comments
Closed

Why is Position's timestamp property nullable? #1145

jjoelson opened this issue Oct 3, 2022 · 3 comments
Labels
P2 Important issues not at the top of the work list. P3 Issues that we currently consider unimportant. type: enhancement New feature or request

Comments

@jjoelson
Copy link

jjoelson commented Oct 3, 2022

Thanks for creating this great package!

I was wondering why the Position timestamp property is DateTime? instead of DateTime. I did a quick scan of the getPositionStream implementation for iOS and Android and it looks like CLLocation.timestamp and android.location.Location.getTime() are the sources and should always return a value.

I didn't dive into the other platform code because I'm only using iOS and Android. Can I can safely assume that timestamp will always be non-null on iOS and Android? Or are there scenarios where it will be null?

@TimHoogstrate
Copy link
Contributor

Dear @jjoelson,

Thanks for your support. It looks like a great improvement. Therefore, I label this issue as an enhancement.

Kind regards,

@TimHoogstrate TimHoogstrate added type: enhancement New feature or request P2 Important issues not at the top of the work list. P3 Issues that we currently consider unimportant. labels Jul 24, 2023
@TimHoogstrate
Copy link
Contributor

TimHoogstrate commented Oct 25, 2023

Dear @jjoelson,

In the changelog of version 2.0.1 it is stated that:

"Bug fix where a null reference exception occurs because the timestamp of the Position could be null when fetching a Placemark using the placemarkFromAddress or placemarkFromCoordinates methods."

So it seems to have a valid reason to be there.

Kind regards,

@TimHoogstrate
Copy link
Contributor

Resolved by 1362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Important issues not at the top of the work list. P3 Issues that we currently consider unimportant. type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants