-
-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[platform_interface] 1145 removed optional timestamp #1362
[platform_interface] 1145 removed optional timestamp #1362
Conversation
# Conflicts: # geolocator/CHANGELOG.md
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
Could you explain why this change is necessary? In your earlier comment you explain why the timestamp should be nullable. |
We have discussed this off-line. The reason the timestamp is nullable is because in old versions the Since the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* removed optional timestamp * Changed changelog text * Removed accidental committed generated_plugins.cmake * changed platform interface version * Update CHANGELOG.md
Resolves enhancement: 1145, by removing the optional permission timestamp from the platform interface.
Pre-launch Checklist
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.md
to add a description of the change.///
).main
.dart format .
and committed any changes.flutter analyze
and fixed any errors.