Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[platform_interface] 1145 removed optional timestamp #1362

Merged

Conversation

TimHoogstrate
Copy link
Contributor

@TimHoogstrate TimHoogstrate commented Oct 30, 2023

Resolves enhancement: 1145, by removing the optional permission timestamp from the platform interface.

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
...or_platform_interface/lib/src/models/position.dart 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@TimHoogstrate TimHoogstrate changed the title removed optional timestamp [platform_interface] 1145 removed optional timestamp Oct 31, 2023
@TimHoogstrate TimHoogstrate marked this pull request as ready for review November 1, 2023 10:38
@JeroenWeener
Copy link
Contributor

Could you explain why this change is necessary? In your earlier comment you explain why the timestamp should be nullable.

#1145 (comment)

@mvanbeusekom
Copy link
Member

Could you explain why this change is necessary? In your earlier comment you explain why the timestamp should be nullable.

#1145 (comment)

We have discussed this off-line. The reason the timestamp is nullable is because in old versions the Position class was also used to represent positions resolved using geocoding. However since version 6.0.0 support for geocoding has been moved out of the geolocator plugin and into it's own plugin (geocoding).

Since the Position class now only represents positions acquired from the the geolocation services provided by the device (GPS, Network, etc...) a timestamp should always be included and therefore there is no need to keep it optional.

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvanbeusekom mvanbeusekom merged commit 5b07c28 into Baseflow:main Nov 6, 2023
3 checks passed
hatch01 pushed a commit to onyx-lyon1/flutter-geolocator that referenced this pull request Sep 8, 2024
* removed optional timestamp

* Changed changelog text

* Removed accidental committed generated_plugins.cmake

* changed platform interface version

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants