Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure timestamp is not null #1377

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Ensure timestamp is not null #1377

merged 1 commit into from
Nov 14, 2023

Conversation

mvanbeusekom
Copy link
Member

This PR ensures the Position object always contains a timestamp as required by the latest version of the geolocator_platform_interface package.

Solves #1371

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
geolocator_linux/lib/src/geoclue_x.dart 100.00% <100.00%> (ø)

... and 16 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

JeroenWeener
JeroenWeener approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@JeroenWeener JeroenWeener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvanbeusekom mvanbeusekom merged commit b311084 into main Nov 14, 2023
3 of 4 checks passed
@mvanbeusekom mvanbeusekom deleted the issue/1371 branch November 14, 2023 09:40
hatch01 pushed a commit to onyx-lyon1/flutter-geolocator that referenced this pull request Sep 8, 2024
@mvanbeusekom @hatch01
Ensure timestamp is not null (Baseflow#1377)
9bcbaad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeroenWeener JeroenWeener JeroenWeener approved these changes

@TimHoogstrate TimHoogstrate Awaiting requested review from TimHoogstrate

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvanbeusekom @JeroenWeener