Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic generation of Timestamp for Positioned.fromMap if it is not… #1411

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

guplem
Copy link
Contributor

@guplem guplem commented Jan 22, 2024

Should fix #1392

The fromMap method of Positioned now checks if the timestamp exists, and if it does not exist, assume that the timestamp is "now".

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b311084) 94.73% compared to head (5162e24) 100.00%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #1411      +/-   ##
===========================================
+ Coverage   94.73%   100.00%   +5.26%     
===========================================
  Files           4        13       +9     
  Lines         114       246     +132     
===========================================
+ Hits          108       246     +138     
+ Misses          6         0       -6     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for this contribution

@mvanbeusekom mvanbeusekom merged commit 113e628 into Baseflow:main Jan 31, 2024
3 checks passed
@guplem guplem deleted the fix-1392-null-timestamp branch January 31, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants