Add new feature to base.plugin.bash

[TheMadTomato]

Description

New function labeled rex() servers a single purpose. Replace the file extensions of multiple file at once. File extensions usually does not quite matter in bash, but there is a few cases when one might needs to and this function simplifies the process from multiple commands into one.

The Function

function rex() {
	about 'mass replace of the extension of multiple files'
 	param '1: extension to replace'
  	param '2: new extenstion'
   	example 'rex txt md'
    	group 'base'
	local ext2replace="${1:-}"
 	local newext="${2:-}"
  	local files=(`ls *.$ext2replace`)
   	for file in "${files[@]}"; do mv "$file" "${file/%.$ext2replace/.$newext}"; done
}

How Has This Been Tested?

Created multiple test files with different extensions, than proceeded to use rex to only change the specified extension which worked flawlessly

Testing Environment

• OS : Debian GNU/Linux 12 (bookworm) x86_64
• VER: 6.1.0-21-amd64
• Bash Ver: 5.2.12
• Computer: Lenovo Thinkpad P52s

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• If my change requires a change to the documentation, I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
• I have added tests to cover my changes, and all the new and existing tests pass.

[seefood]

This is a bit too short and already taken by a function for the fasd plugin. please rename to something that won't clobber or move to your private alias file.

[seefood]

There is already a package in Ubuntu and other distros called rex and I would rather not have them clash. Could you consider naming it renex or rext?

[seefood]

The indentation is mixed spaces and tabs, please align all to just tabs. Thanks!

[akinomyoga]

Suggested change

	local files=(`ls *.$ext2replace`)
	local files=(*."$ext2replace")

`ls *.$foo` is subject to unwanted word splitting and pathname expansions. One should simply use *."$foo". In this case, one should check the generated filenames exist because the literal '*.txt' remains if the matching filename does not exist and shopt -s nullglob is not set.

[akinomyoga]

• $ext2replace should be quoted. Otherwise, $ext2replace is treated as a glob pattern.
• In Bash >= 5.1, when pathsub_replacement is turned on (which is the default), & inside $newext would be expanded to the original matching. It is unusual to include & in the filename extension, but it would still cause unexpected results when the user specifies such an extension.
  • One naive workaround would be to quote $newext as "$newext", but it causes another issue with Bash <= 4.2 or when shopt -s compat42 is turned on: For example, a=x.dat; echo "${x/".dat"/".txt"}" would result in a".txt".
  • To properly handle this, one needs to save, unset, and restore the shell setting patsub_replacement.
  • Or another way to work it around is to assign the replacement result to a shell variable with no quoteing of the entire RHS: local dst=${file/%."$ext2replace"/."$newext"}. This works under an arbitrary combination of shopt -q patsub_replacement and shopt -q compat42.

[seefood]

@TheMadTomato hey paul, would you like to try merging with the master and fix the suggested problems please?

[TheMadTomato]

Hello, Sorry i missed your comments.
I will tend to all the points you have given me very soon.