Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Adopt a release & PHP / dependency version support policy #173

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

acoulton
Copy link
Contributor

For discussion as much as anything else...

Following the discussion / agreement in Behat/Behat#1503 I have drafted a docs page outlining our policy on supporting PHP and symfony versions.

I think we should also have a public policy on support for Behat versions themselves, so I have proposed one here. I think we should give users a sense of what to expect (to give them confidence to choose Behat, as much as anything) but I think we also need to be realistic about our maintainer / community resources. Therefore I think the rolling support life I've suggested makes more sense than committing to e.g. a fixed schedule for releasing and dropping major versions.

My suggestion is that this should live as a page in the docs, and then we'd also link to it from the Behat/Behat README and potentially the top of the CHANGELOG too.

Questions, challenges, and alternate opinions are very welcome!

@acoulton
Copy link
Contributor Author

The RTD webhook is now working :) rendered version of the new page available to preview at https://behat--173.org.readthedocs.build/en/173/releases.html

Copy link
Contributor

@carlos-granados carlos-granados left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment, otherwise looks good

releases.rst Outdated
Major Released Bugfix EOL Security EOL
======= ========== ============ ============ =====================================================================
`v2.x`_ July 2011 June 2015 June 2015 `Changelog <https://github.com/Behat/Behat/blob/2.5/CHANGES.md>`__
`v3.x`_ April 2014 *>12 months* *>24 months* `Changelog <https://github.com/Behat/Behat/blob/master/CHANGES.md>`__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a bit confusing, some users may read this as "bugfixes ended 12 months after April 2014 and security fixes ended 24 months after April 2014"? Maybe adopt what other tools do which to show which versions are maintained, which are security fixes only, which are end of life and even show future unreleased versions. So we could list version 2.x as end of life for bugs and security, 3.x as maintained and 4.x as unreleased. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlos-granados thanks for the review, and yes, I wondered if that would be clear enough to a new reader.

I've reworked the structure of the page to separate out the current from unmaintained versions, I think it's easier to follow now, let me know what you think.

I haven't listed 4.x yet as I don't think there's actually anything really on it yet, and it is out of date with 3.x. We can add it when we start working on it properly.

@carlos-granados
Copy link
Contributor

The RTD webhook is now working :) rendered version of the new page available to preview at https://behat--173.org.readthedocs.build/en/173/releases.html

Great 🎉 Can we somehow generate this link automatically somewhere when we create a PR?

@stof
Copy link
Member

stof commented Nov 12, 2024

@carlos-granados it is actually available in the GitHub UI of the PR. That's the URL for the details link of the readthedocs.org build (well, the homepage of the doc, not that specific page):
image

releases.rst Outdated Show resolved Hide resolved
releases.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@carlos-granados carlos-granados left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, I think it is less confusing. Just a couple of small changes needed

releases.rst Outdated
======= ========== ========== ============ =====================================================================
Major Released Bugfix EOL Security EOL
======= ========== ========== ============ =====================================================================
`v3.x`_ April 2014 See below See below `Changelog <https://github.com/Behat/Behat/blob/master/CHANGES.md>`__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be https://github.com/Behat/Behat/blob/master/CHANGELOG.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks

releases.rst Outdated
Support for PHP and dependency versions
---------------------------------------

Behat only supports current versions of PHP and third-party dependency packages (e.g. symfony components).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably use Symfony (with uppercase S) everywhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks

@carlos-granados
Copy link
Contributor

BTW, love that now a version is built for each PR, this makes it much easier to review proposals

Co-authored-by: Christophe Coevoet <[email protected]>
@acoulton
Copy link
Contributor Author

BTW, love that now a version is built for each PR, this makes it much easier to review proposals

Yeah, I had a feeling that was going to be super helpful

Copy link
Contributor

@carlos-granados carlos-granados left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @acoulton

@carlos-granados carlos-granados merged commit bf23f39 into Behat:v3.0 Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants