-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP Config - Suites #179
PHP Config - Suites #179
Conversation
I don't think we want to maintain separate versions of the documentation for each minor version (especially given that older minor versions don't receive updates according to our versioning policy). It is unfortunate that the documentation branch is named |
ad8cc68
to
8d5a59c
Compare
@acoulton I've updated this PR with last changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me.
I agree with the others that we should only have one branch per major-version-series in the docs, and that we should just migrate the docs examples from yaml to PHP rather than showing both.
I'd suggest we add one single page for the YAML config that just shows a single example of a complete YAML file with all available options, perhaps with comments to mark which PHP config objects they equate to?
d71ef0b
to
837272b
Compare
837272b
to
218b760
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @loic425 - I've just rebased it to pick up an unrelated linting issue that was fixed in 3.0 since you opened this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @loic425
With the current state of Behat/Behat#1539
I think we need to create a specific branch "3.17".
Overview here https://behat--179.org.readthedocs.build/en/179/user_guide/configuration/suites.html#suite-paths
The filters implementation is still on PR review.