2531 command button panel #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also enhances the customizable panel API by making templates load dynamically when requested.
tastybento
commented
Oct 20, 2024
| @@ -466,16 +464,6 @@ public boolean loadSettings() { | |||
| return false; | |||
| } | |||
|
|
|||
| log("Saving default panels..."); | |||
There was a problem hiding this comment.
No longer required because they are loaded from Jar if not found
tastybento
commented
Oct 20, 2024
| @@ -346,7 +346,7 @@ private CompositeCommand getCommandFromArgs(String[] args) { | |||
| * | |||
| * @return IslandsManager | |||
| */ | |||
| protected IslandsManager getIslands() { | |||
| public IslandsManager getIslands() { | |||
tastybento
commented
Oct 20, 2024
| @@ -362,9 +362,8 @@ ItemSlot nextItemSlot() { | |||
| * this button is present. | |||
| * | |||
| * @return Map that links button type to amount in the gui. | |||
| * @deprecated Use {@link #amount(String)} instead. | |||
| * Use {@link #amount(String)} instead. | |||
There was a problem hiding this comment.
This doesn't seem to be deprecated, and is used a lot.
tastybento
commented
Oct 20, 2024
| BentoBox.getInstance().logError(file.getAbsolutePath() + " does not exist for panel template"); | ||
| // Return as file does not exist. | ||
| return null; | ||
| // Try to get it from the JAR |
There was a problem hiding this comment.
If it's not there, then try and get it from the Jar.
tastybento
commented
Oct 20, 2024
| import world.bentobox.bentobox.api.user.User; | ||
|
|
||
| /** | ||
| * @author tastybento |
There was a problem hiding this comment.
This is for use by all customizable panels.
tastybento
commented
Oct 20, 2024
| @@ -0,0 +1,59 @@ | |||
| /** | |||
| * | |||
tastybento
commented
Oct 20, 2024
| title: "&2&l Your island homes" | ||
| buttons: | ||
| # This button is used for displaying islands to teleport to | ||
| name: "&l [name]" |
There was a problem hiding this comment.
Keep it simple - just name right now.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.