Tweak season checking code

.luacheckrc

@@ -56,9 +56,6 @@ files["**/Loader.lua"].ignore = {
 	"11[23]/SlashCmdList",
 	"11[23]/hash_SlashCmdList",
 }
-files["**/API.lua"].ignore = {
-	"113/geterrorhandler",
-}
 files["**/AutoRole.lua"].ignore = {
 	"113/RolePollPopup",
 	"113/UnitGroupRolesAssigned",
@@ -68,7 +65,6 @@ files["**/AutoRole.lua"].ignore = {
 files["**/Core/BossPrototype.lua"].ignore = {
 	"113/C_Item",
 	"113/C_NamePlate",
-	"113/C_Seasons",
 	"113/C_UIWidgetManager",
 	"113/C_UnitAuras",
 	"113/GetNumGroupMembers",
@@ -81,7 +77,6 @@ files["**/Core/BossPrototype.lua"].ignore = {
 files["**/Core/BossPrototype_Classic.lua"].ignore = {
 	"113/C_Item",
 	"113/C_NamePlate",
-	"113/C_Seasons",
 	"113/C_UIWidgetManager",
 	"113/C_UnitAuras",
 	"113/GetNumGroupMembers",

Core/BossPrototype.lua

@@ -30,7 +30,7 @@ local BigWigsAPI = BigWigsAPI
 local L = BigWigsAPI:GetLocale("BigWigs: Common")
 local LibSpec = LibStub("LibSpecialization", true)
 local loader = BigWigsLoader
-local isClassic, isRetail, isClassicEra, isCata = loader.isClassic, loader.isRetail, loader.isVanilla, loader.isCata
+local isClassic, isRetail, isClassicEra, isCata, season = loader.isClassic, loader.isRetail, loader.isVanilla, loader.isCata, loader.season
 local C_EncounterJournal_GetSectionInfo = isCata and function(key)
 	return C_EncounterJournal.GetSectionInfo(key) or BigWigsAPI:GetLocale("BigWigs: Encounter Info")[key]
 end or isRetail and C_EncounterJournal.GetSectionInfo or function(key)
@@ -1615,17 +1615,10 @@ function boss:Vanilla()
 	return isClassicEra
 end
 
-do
-	local GetActiveSeason = C_Seasons and C_Seasons.GetActiveSeason
-	local season = 0
-	if GetActiveSeason then
-		season = GetActiveSeason() or 0
-	end
-	--- Get the current season.
-	-- @return number
-	function boss:GetSeason()
-		return season
-	end
+--- Get the current season.
+-- @return number
+function boss:GetSeason()
+	return season
 end
 
 --- Get the mob/npc id from a GUID.

Core/BossPrototype_Classic.lua

@@ -30,7 +30,7 @@ local BigWigsAPI = BigWigsAPI
 local L = BigWigsAPI:GetLocale("BigWigs: Common")
 local LibSpec = LibStub("LibSpecialization", true)
 local loader = BigWigsLoader
-local isClassic, isRetail, isClassicEra, isCata = loader.isClassic, loader.isRetail, loader.isVanilla, loader.isCata
+local isClassic, isRetail, isClassicEra, isCata, season = loader.isClassic, loader.isRetail, loader.isVanilla, loader.isCata, loader.season
 local C_EncounterJournal_GetSectionInfo = isCata and function(key)
 	return C_EncounterJournal.GetSectionInfo(key) or BigWigsAPI:GetLocale("BigWigs: Encounter Info")[key]
 end or isRetail and C_EncounterJournal.GetSectionInfo or function(key)
@@ -1688,17 +1688,10 @@ function boss:Vanilla()
 	return isClassicEra
 end
 
-do
-	local GetActiveSeason = C_Seasons and C_Seasons.GetActiveSeason
-	local season = 0
-	if GetActiveSeason then
-		season = GetActiveSeason() or 0
-	end
-	--- Get the current season.
-	-- @return number
-	function boss:GetSeason()
-		return season
-	end
+--- Get the current season.
+-- @return number
+function boss:GetSeason()
+	return season
 end
 
 --- Get the mob/npc id from a GUID.

Init.lua

@@ -1,3 +1,4 @@
 
 local _, tbl = ...
 tbl.isRetail = true
+tbl.season = 0

Init_Cata.lua

@@ -2,3 +2,4 @@
 local _, tbl = ...
 tbl.isClassic = true
 tbl.isCata = true
+tbl.season = 0

Init_TBC.lua

@@ -2,3 +2,4 @@
 local _, tbl = ...
 tbl.isClassic = true
 tbl.isTBC = true
+tbl.season = 0

Init_Vanilla.lua

@@ -2,4 +2,5 @@
 local _, tbl = ...
 tbl.isClassic = true
 tbl.isVanilla = true
-tbl.isSeasonOfDiscovery = C_Seasons.GetActiveSeason() == 2
+tbl.season = C_Seasons and C_Seasons.GetActiveSeason() or 0
+tbl.isSeasonOfDiscovery = tbl.season == 2

Init_Wrath.lua

@@ -2,3 +2,4 @@
 local _, tbl = ...
 tbl.isClassic = true
 tbl.isWrath = true
+tbl.season = 0

Loader.lua

@@ -27,6 +27,7 @@ do
 	public.isRetail = tbl.isRetail
 	public.isClassic = tbl.isClassic
 	public.isVanilla = tbl.isVanilla
+	public.season = tbl.season
 	public.isSeasonOfDiscovery = tbl.isSeasonOfDiscovery
 	public.isTBC = tbl.isTBC
 	public.isWrath = tbl.isWrath