Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update locale #1865

Merged
merged 11 commits into from
Sep 29, 2024
Merged

Update locale #1865

merged 11 commits into from
Sep 29, 2024

Conversation

Zurent
Copy link
Contributor

@Zurent Zurent commented Sep 29, 2024

"Sorry, I think I closed the previous one… I’m still not getting along with Git haha. I believe I’ve fixed the issues you mentioned.

Regarding the issue you pointed out: L.adds_spawning = ‘Enemies appearing’ – plural I assume this should be ‘apareciendos’?

It’s correct in plural in Spanish, you only need to change ‘Enemigos’ and not both words to ‘Enemigos apareciendos’.

If there’s any mistake or anything else, just let me know."

Added missing translations in Locales/enES.lua
Added missing translations in Locales/common.esES.lua
Added missing translations in Plugins/Locales/esES.lua
Fixed:
L.link_both = "%s + %s están vinculados"
L.link_both_icon = "|T13700%d:0|t%s + |T13700%d:0|t%s están vinculados"
@funkydude
Copy link
Member

You didn't fix L.adds_spawned_count = "%d |4enemigo:enemigos; aparecido(s)"

|4 is a special code that changes the text after a number. If you want to have it say "1 enemigo aparecido" and "2 enemigos aparecidos" then you need to change it to this:

L.adds_spawned_count = "%d |4enemigo aparecido:enemigos aparecidos;"

Fixed: L.adds_spawned_count = "%d |4enemigo aparecido:enemigos aparecidos;" in Core/Locales/common.esES.lua
@Zurent
Copy link
Contributor Author

Zurent commented Sep 29, 2024

Sorry if I missed that mistake, my bad… If you see any more errors or anything else, just let me know. I’m here to help.

@funkydude funkydude merged commit 816fc23 into BigWigsMods:master Sep 29, 2024
1 check passed
@funkydude
Copy link
Member

Nice work! Your changes were merged.
There's still a few translations missing though if you are interested.

In BigWigs/Locales

--L.SOD = "Season of Discovery"
--L.hardcore = "Hardcore"

"Season of Discovery" is a special season running in World of Warcraft Classic era (vanilla)
"Hardcore" is a special difficulty running in World of Warcraft Classic era (vanilla) where you cannot die or your character will be deleted.

In BigWigs/Plugins/Locales

--L.victoryOption = "You were victorious"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants