Firelands/Alysrazor: Fix Firestorm bar

[stako]

Currently, the FirestormOver method is supposed to be triggered by a SPELL_AURA_REMOVED combat log event:
self:Log("SPELL_AURA_REMOVED", "FirestormOver", 100744)

Turns out there are no aura-related events for Firestorm firing in the combat log for some reason.

Confirmed that the spell ID is correct for the aura.

For a solution, using self:SimpleTimer(function() self:FirestormOver(args) end, 10) in the Firestorm method instead of self:Log("SPELL_AURA_REMOVED", "FirestormOver", 100744)

[funkydude]

That wont work unfortunately, you cannot trust the args table hasn't changed in the duration the Firestorm takes to end. It might, but it might not. The functions don't create new tables each time they are called.

[stako]

Ah, didn't realize that - must be why the lint check failed on the first commit. It's rectified in the second commit though - the args table isn't used by the FirestormOver method at all in that one.

Despite that, this week I'll see if UNIT_SPELLCAST_CHANNEL_STOP works.

[funkydude]

That event will probably work, but I've also asked Blizz to remove the "no aura log" spell flag to get it shown in the combat log.

[stako]

Tested UNIT_SPELLCAST_CHANNEL_STOP today, works just fine. Adjusted PR

[funkydude]

Sorry, merged, thank you!