Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dask container recipe #545

Merged
merged 22 commits into from
Nov 16, 2023
Merged

Dask container recipe #545

merged 22 commits into from
Nov 16, 2023

Conversation

cgoina
Copy link
Contributor

@cgoina cgoina commented Nov 14, 2023

Submitting a Container

(If you're requesting for a new container, please check the procedure described here.

Check BioContainers' Dockerfile specifications

Checklist

  1. Misc
  • My tool doesn't exist in BioConda
  • The image can be built
  1. Metadata
  • LABEL base_image
  • LABEL version
  • LABEL software.version
  • LABEL about.summary
  • LABEL about.home
  • LABEL about.license
  • MAINTAINER
  1. Extra (optionals)
  • I have written tests in test-cmds.txt
  • LABEL extra.identifier
  • LABEL about.documentation
  • LABEL about.license_file
  • LABEL about.tags

Check BioContainers' Dockerfile metadata

@cgoina
Copy link
Contributor Author

cgoina commented Nov 14, 2023

This container contains scripts that we use in our nextflow dask workflow, which we intend to submit to nf-core.

@cgoina
Copy link
Contributor Author

cgoina commented Nov 15, 2023

I made the change to chmod in a separate step

@biocontainers-bot
Copy link
Collaborator

software.version label not matching directory version name

@biocontainers-bot
Copy link
Collaborator

Could not find the defined biotools entry, please check its name on biotools

@cgoina
Copy link
Contributor Author

cgoina commented Nov 15, 2023

I saw the failure "Found some errors: software.version label not matching directory version name" - I named the folder based on the dask version, python version and os version - should I include all these in the software.version label? The current software version label is only showing the dask version

@cgoina
Copy link
Contributor Author

cgoina commented Nov 15, 2023

I updated the software.version label to reflect the dir name

@biocontainers-bot
Copy link
Collaborator

Could not find the defined biotools entry, please check its name on biotools

@biocontainers-bot
Copy link
Collaborator

No test-cmds.txt (test file) present, skipping tests

@mboudet
Copy link
Contributor

mboudet commented Nov 16, 2023

Ok, you should just remove the extra.identifiers.biotools="dask" , since I don't think it exists in biotools ?

@biocontainers-bot
Copy link
Collaborator

No biotools label defined, please check if tool is not already defined in biotools (https://bio.tools) and add extra.identifiers.biotools label if it exists. If it is not defined, you can ignore this comment.

@biocontainers-bot
Copy link
Collaborator

No test-cmds.txt (test file) present, skipping tests

@mboudet
Copy link
Contributor

mboudet commented Nov 16, 2023

Seems fine to me, merging.

@mboudet mboudet merged commit d7c6b97 into BioContainers:master Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants