Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank for for the VariantAnnotation package, it makes it very easy to annotate mutations found in VCF files!
There is, however, one limitation that I find unnecessarily restrictive: The
predictCoding
method expects aTxDb
object as its second argument and will not be able to process gene and transcript annotations otherwise.I propose that the limitation here should be any object that supports the
cdsBy
andtranscriptsBy
methods, e.g. anEnsDb
object. As they do not share a common base class, I allowANY
type that will then error if the associated methods are not found.In particular, the code that previously failed now works successfully: