Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command to create a Python wheel through setuptools #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

allardhoeve
Copy link

@allardhoeve allardhoeve commented Jun 11, 2019

There is packaging in place to build a Python package, but it does not currently compile correct wheels. This PR adds a target to build a wheel that compiles the .whl file through standard Python tooling: setuptools.

This creates a binary that has the correct name for current Pythons (_btk.cpython-37m-darwin.so and such).

This can then be released through Pipy (which is currently behind) for various platforms, without the need for users to compile anything.

(Contains #26)

@aaa34169
Copy link

Hello

i am compiling with python 3.7 under windows 7 ( cmake 3.3 and nmake). I am not an expert in c++ compiling
The wrapping works fine in release mode but i suppose i should get a folder "package" inside "bin". I don t have it ! I suspect it s beause i have this warning with cmake during configuration

Make Warning (dev) at Packaging/CMakeLists.txt:1 (ADD_CUSTOM_TARGET):
Policy CMP0037 is not set: Target names should not be reserved and should
match a validity pattern. Run "cmake --help-policy CMP0037" for policy
details. Use the cmake_policy command to set the policy and suppress this
warning.

The target name "package" is reserved or not valid for certain CMake
features, such as generator expressions, and may result in undefined
behavior.
This warning is for project developers. Use -Wno-dev to suppress it.

any help would be appreciated

@aaa34169
Copy link

here are all warnings i got :

CMake Warning (dev) at Packaging/CMakeLists.txt:1 (ADD_CUSTOM_TARGET):
Policy CMP0037 is not set: Target names should not be reserved and should
match a validity pattern. Run "cmake --help-policy CMP0037" for policy
details. Use the cmake_policy command to set the policy and suppress this
warning.

The target name "package" is reserved or not valid for certain CMake
features, such as generator expressions, and may result in undefined
behavior.
This warning is for project developers. Use -Wno-dev to suppress it.

CMake Warning (dev) at Packaging/CMakeLists.txt:24 (GET_TARGET_PROPERTY):
Policy CMP0026 is not set: Disallow use of the LOCATION target property.
Run "cmake --help-policy CMP0026" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.

The LOCATION property should not be read from target "_btk". Use the
target name directly with add_custom_command, or use the generator
expression $<TARGET_FILE>, as appropriate.

This warning is for project developers. Use -Wno-dev to suppress it.

CMake Warning (dev) at CMakeLists.txt:373 (EXPORT_LIBRARY_DEPENDENCIES):
Policy CMP0033 is not set: The export_library_dependencies command should
not be called. Run "cmake --help-policy CMP0033" for policy details. Use
the cmake_policy command to set the policy and suppress this warning.
This warning is for project developers. Use -Wno-dev to suppress it.

@allardhoeve
Copy link
Author

allardhoeve commented Jun 16, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants