-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a command to create a Python wheel through setuptools #27
base: master
Are you sure you want to change the base?
Conversation
Hello i am compiling with python 3.7 under windows 7 ( cmake 3.3 and nmake). I am not an expert in c++ compiling
any help would be appreciated |
here are all warnings i got :
|
Hey!
I'm also not very experienced, but I had hoped you were :)
I think we can safely rename the package target to something else.
I'll rename it later this week and see what happens.
Allard
…On Sun, Jun 16, 2019 at 6:02 PM Fabien Leboeuf ***@***.***> wrote:
Hello
i am compiling with python 3.7 under windows 7 ( cmake 3.3 and nmake). I
am not an expert in c++ compiling
The wrapping works fine in release mode but i suppose i should get a
folder "package" inside "bin". I don t have it ! I suspect it s beause i
have this warning with cmake during configuration
Make Warning (dev) at Packaging/CMakeLists.txt:1 (ADD_CUSTOM_TARGET):
Policy CMP0037 is not set: Target names should not be reserved and should
match a validity pattern. Run "cmake --help-policy CMP0037" for policy
details. Use the cmake_policy command to set the policy and suppress this
warning.
The target name "package" is reserved or not valid for certain CMake
features, such as generator expressions, and may result in undefined
behavior.
This warning is for project developers. Use -Wno-dev to suppress it.
any help would be appreciated
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#27?email_source=notifications&email_token=AAJUJBXJ3AJIJSZGJWFNJKLP2ZP2JA5CNFSM4HW35RVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXZQAWA#issuecomment-502464600>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJUJBRXVT2SIVVYQRUG7LDP2ZP2JANCNFSM4HW35RVA>
.
|
There is packaging in place to build a Python package, but it does not currently compile correct wheels. This PR adds a target to build a wheel that compiles the
.whl
file through standard Python tooling:setuptools
.This creates a binary that has the correct name for current Pythons (
_btk.cpython-37m-darwin.so
and such).This can then be released through Pipy (which is currently behind) for various platforms, without the need for users to compile anything.
(Contains #26)