-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix procdump (bis) #1562
Fix procdump (bis) #1562
Conversation
…buffer instead at initial allocation.
…sliver into v1.6.0/fix-procdump
Do not merge yet. Fixed the issue in debug mode, but somehow it crashes in non-debug implants. |
…sliver into v1.6.0/fix-procdump
Finally found a way to make this work. Ready for review. Final solution doesn't rely on preallocating memory with |
Fix the Windows
procdump
command implementation by removing the dynamic heap re-allocation of the dump buffer. This caused issues when dumping large processes. This PR addresses that by pre-allocating memory of the size of the current process's memory footprint plus an additional 20 MB safety net in case the target process's memory grows between the start and stop of the memory dump.It's a bit less elegant, but a lot safer.