backend: add isHidden property in exchange deals #3178
Conversation
Beerosagos
force-pushed
the
hidden-refactor
branch
from
494b613 to
243a321
Compare
| label = 'buy.exchange.creditCard'; | ||
| break; | ||
| // case 'sofort': | ||
| // case 'bancontact': |
There was a problem hiding this comment.
Not sure if we want to add icons for sofort and bancontact 🤔
There was a problem hiding this comment.
we don't show them at the moment, lets rethink the badges first before spending time on icons etc.
| {isDarkMode ? <Bank /> : <BankDark />} | ||
| {t('buy.exchange.bankTransfer')} | ||
| </span> | ||
| ); |
There was a problem hiding this comment.
please keep the return style.
when reading the code, I find it much easier to read also see next comment.
There was a problem hiding this comment.
Ack, I just thought that with other payment methods, it would duplicate too much code, but since we are not adding any other method that's absolutely fine.
| return ( | ||
| <span className={style.paymentMethodName}> | ||
| {icon} | ||
| {label && t(label)} |
There was a problem hiding this comment.
almost the entire codebase uses t('keyname' so it is easy to find again.
but see my other comment, then this variable isn't needed anyway.
| label = 'buy.exchange.creditCard'; | ||
| break; | ||
| // case 'sofort': | ||
| // case 'bancontact': |
There was a problem hiding this comment.
we don't show them at the moment, lets rethink the badges first before spending time on icons etc.
This allows to hide specific deals in the frontend deals list. e.g. when the exchange offers several payment methods with different fees. The deals are still used to show all the payments and fees in the info box.
Beerosagos
force-pushed
the
hidden-refactor
branch
from
243a321 to
d41595b
Compare
|
@thisconnect updated, PTAL 🙏 |
| @@ -236,7 +239,7 @@ func GetExchangeDeals(account accounts.Interface, regionCode string, action Exch | |||
| bestDealIndex := 0 | |||
| for i, deal := range deals { | |||
| oldBestDeal := deals[bestDealIndex] | |||
| if deal.Fee < oldBestDeal.Fee { | |||
| if !deal.IsHidden && deal.Fee < oldBestDeal.Fee { | |||
There was a problem hiding this comment.
[out of scope for this PR] I still think that if we keep the "best" badge we need to decide how to deal with multiple deals offering the same fee
This allows to hide specific deals in the frontend deals list. e.g. when the exchange offers several payment methods with different fees. The deals are still used to show all the payments and fees in the info box.