Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add perl modules for filebuster #2764

Merged
merged 3 commits into from
May 14, 2020
Merged

Add perl modules for filebuster #2764

merged 3 commits into from
May 14, 2020

Conversation

aancw
Copy link
Member

@aancw aancw commented May 14, 2020

Fix for filebuster #2759 (comment)

@aancw aancw requested review from Edu4rdSHL and noptrix as code owners May 14, 2020 05:24
@aancw
Copy link
Member Author

aancw commented May 14, 2020

We need to merge perl-io-async aur to blackarch repo?

==> Installing missing dependencies...
error: target not found: perl-io-async
==> ERROR: 'pacman' failed to install missing dependencies.

==> Missing dependencies:
  -> perl-yaml
  -> perl-switch
  -> perl-net-dns
  -> perl-list-moreutils
  -> perl-io-socket-ssl
  -> perl-io-socket-socks-wrapper
  -> perl-uri
  -> perl-furl
  -> perl-http-parser-xs
  -> perl-class-accessor-lite
  -> perl-cache-lru
  -> perl-net-dns-lite
  -> perl-exporter-tiny
  -> perl-io-async

==> Checking buildtime dependencies...
==> Installing missing dependencies...

@ikstream
Copy link
Member

If you add commits, please remember the Commit style (pkgname: changes).
Yes, all missing dependencies should be added to our repos.

@aancw
Copy link
Member Author

aancw commented May 14, 2020

If you add commits, please remember the Commit style (pkgname: changes).

Noted. Sorry for my bad. I will try to move perl-io-async to blackarch repo then.

@aancw
Copy link
Member Author

aancw commented May 14, 2020

Deps list:

  • perl-io-async
  • perl-future
    • perl-test-fatal
    • perl-test-identity
    • perl-test-refcount

@noraj
Copy link
Contributor

noraj commented May 14, 2020

@ikstream @aancw For python and ruby package that have too many dependencies or sub dependencies we package them in a dedicated virtual environment rather than packaging hundreds of dependencies that will be hard to maintain on long terms. Maybe we should take the same approach here and package it in a virtual perl environment ? I don't know how can this work as I'm not familiar with perl.

@aancw
Copy link
Member Author

aancw commented May 14, 2020

@noraj I've figured that perl-test-refcount 0.08 have Makefile.PL and 0.10 doesn't have. So the devel::mat is not needed and I've updated the list.

I think it's good idea for perl environment.

@aancw aancw changed the title Add perl-io-async for filebuster Add perl modules for filebuster May 14, 2020
@noptrix
Copy link
Contributor

noptrix commented May 14, 2020

thank you @aancw

@noptrix noptrix merged commit c0f9297 into master May 14, 2020
@noraj noraj deleted the filebuster branch May 14, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants