Feature/postlist 무한스크롤 기능 보류 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimKwon
approved these changes
Mar 7, 2021
| if (!token) { | ||
| this.fetchMainPosts(0); | ||
| await dispatch(getMainPosts(0, mainPageNum)); |
There was a problem hiding this comment.
31번, 34번 라인 혹시 vscode에서 이 경고 안 뜨시나요
'await' has no effect on the type of this expression.ts(80007)
분명 await 붙고 안 붙고에 따라 로더가 포스트 렌더링 전까지 돌고 안돌고의 차이가 존재하는데
정말 신기합니다. 그렇다구요,,,, 👍
There was a problem hiding this comment.
안 그래도 functional component -> useDispatch로 바꾸고 나서 자꾸 워닝 떠서 거슬려 미치겠습니다 !! vscode 설정에서 바꿀 수 있으면 바꾸든지 해야지 원 ...!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
원래는 무한스크롤을 구현하고 PR을 올려야 하는데, 무한스크롤은 맨 마지막으로 미룰까 합니다.
외부 라이브러리도 써보고 했는데 아무래도 직접 짜야할 것 같고, 시간이 좀 걸릴 것 같습니다.
다른 급한 기능 마무리하고 다같이 덤벼봅시다 !!
관련 이슈
#66
변경 사항
PR Point
간단히 테스트만 부탁드립니다 !!
Reference