Ensure elements in std::array are allocated.
#877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug in `inspected::prepare` left the elements of an `std::array` as default allocated. This fails when putting an `std::vector` inside an `std::array`, because the `std::vector`s need to be allocated with the appropriate length.
1uc
force-pushed
the
1uc/array-vector
branch
from
5893f9e to
c8b4053
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #877 +/- ##
==========================================
+ Coverage 84.89% 84.94% +0.05%
==========================================
Files 70 70
Lines 5090 5109 +19
==========================================
+ Hits 4321 4340 +19
Misses 769 769 ☔ View full report in Codecov by Sentry. |
matz-e
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in
inspected::prepareleft the elements of anstd::arrayas default allocated. This fails when putting anstd::vectorinside anstd::array, because thestd::vectors need to be allocated with the appropriate length.