Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ability to modify single cell properties during the simulation run #205

Closed
wants to merge 9 commits into from

Conversation

WeinaJi
Copy link
Collaborator

@WeinaJi WeinaJi commented Oct 22, 2024

Context

Scope

Testing

Review

  • PR description is complete
  • Coding style (imports, function length, New functions, classes or files) are good
  • Unit/Scientific test added
  • Updated Readme, in-code, developer documentation

@bbpbuildbot
Copy link

@WeinaJi
Copy link
Collaborator Author

WeinaJi commented Dec 2, 2024

I am closing this PR because it is not ready.
One issue is about the CoreNEURON reporting where we would like to have one report for all subprocesses 0->t1, t1->t2, t2->tstop. With this change, we could create a report from 0->tstop at the 1st subprocess, and update it in the following subprocesses. However, it conflicts with the major usecase (one single run 0->tstop) where users may ask longer reporting time than the simulation time in the config file and we still create a report up to the simulation time.

@WeinaJi WeinaJi closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants