Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add formula 5.6 from NEN-EN 1992-1-1+C2:2011 #187

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Add formula 5.6 from NEN-EN 1992-1-1+C2:2011 #187

merged 5 commits into from
Mar 22, 2024

Conversation

egarciamendez
Copy link
Member

@egarciamendez egarciamendez commented Mar 16, 2024 •
edited
Loading

Description

Add formula 5.6 from NEN-EN 1992-1-1+C2:2011

Fixes #155
afbeelding

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@egarciamendez egarciamendez self-assigned this Mar 16, 2024
@github-actions GitHub Actions
Copy link

Thank you so much for contributing to Blueprints! This is your Pull Request # 3 to this project.
Your contributions help thousands of engineers work more efficiently and accurately.

Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added!

SZeltaat
SZeltaat reviewed Mar 18, 2024
View reviewed changes
Copy link
Contributor

@SZeltaat SZeltaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Enrique,
I know you haven't asked me to review this PR. I just threw my suggestion to improve the test for latex representation. I haven't reviewed the rest of the PR.
Good luck!

tests/codes/eurocode/nen_en_1992_1_1_c2_2011/chapter_5_structural_analysis/test_formula_5_6.py Outdated Show resolved Hide resolved
bro-wi
bro-wi approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@bro-wi bro-wi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egarciamendez @SZeltaat
Update tests/codes/eurocode/nen_en_1992_1_1_c2_2011/chapter_5_structu…
890d7b9 
…ral_analysis/test_formula_5_6.py

Co-authored-by: Sina Zel taat <[email protected]>
@egarciamendez
Copy link
Member Author

Hi Enrique, I know you haven't asked me to review this PR. I just threw my suggestion to improve the test for latex representation. I haven't reviewed the rest of the PR. Good luck!

I love your proactive approach. Thank you!

@egarciamendez
Merge branch 'main' into 155--feature-request-add-formula-56-from-nen…
130ab52 
…_en_1992_1_1_c2_2011

# Conflicts:
#	docs/source/codes/eurocode/ec2_1992_1_1_2011/formulas.md
@egarciamendez
invalid scape sequence
e8542d7
@egarciamendez egarciamendez merged commit 66f36f5 into main Mar 22, 2024
4 checks passed
@egarciamendez egarciamendez deleted the 155--feature-request-add-formula-56-from-nen_en_1992_1_1_c2_2011 branch March 22, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SZeltaat SZeltaat SZeltaat left review comments

@bro-wi bro-wi bro-wi approved these changes

@johan-tuls johan-tuls Awaiting requested review from johan-tuls

@Simone-de-Rijke Simone-de-Rijke Awaiting requested review from Simone-de-Rijke

Assignees

@egarciamendez egarciamendez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[✨ Feature request]: Add formula 5.6 from NEN_EN_1992_1_1_C2_2011
3 participants
@egarciamendez @bro-wi @SZeltaat