Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#196) Add formula 5.6 from NEN-EN-1993.5:2008 #197

Merged
merged 16 commits into from
Mar 23, 2024
Merged

(#196) Add formula 5.6 from NEN-EN-1993.5:2008 #197

merged 16 commits into from
Mar 23, 2024

Conversation

Klaassicking
Copy link
Collaborator

@Klaassicking Klaassicking commented Mar 19, 2024 •
edited by bro-wi
Loading

Description

Add formula 5.6 from NEN-EN-1993.5:2008

$A_v = t_w \left(h - t_f \right)$

Fixes #196

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@Klaassicking Klaassicking self-assigned this Mar 19, 2024
@Klaassicking Klaassicking linked an issue Mar 19, 2024 that may be closed by this pull request
[✨ Feature request]: Add formula 5.6 from NEN-EN 1993-5 #196
Closed
2 tasks
@github-actions GitHub Actions
Copy link

Thank you so much for contributing to Blueprints! This is your Pull Request # 4 to this project.
Your contributions help thousands of engineers work more efficiently and accurately.

Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added!

bro-wi
bro-wi reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@bro-wi bro-wi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

blueprints/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimate_limit_states/__init__.py Outdated Show resolved Hide resolved
blueprints/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimate_limit_states/formula_5_6.py Outdated Show resolved Hide resolved
blueprints/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimate_limit_states/formula_5_6.py Outdated Show resolved Hide resolved
blueprints/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimate_limit_states/formula_5_6.py Outdated Show resolved Hide resolved
blueprints/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimate_limit_states/formula_5_6.py Outdated Show resolved Hide resolved
tests/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimate_limit_states/__init__.py Outdated Show resolved Hide resolved
tests/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimate_limit_states/test_formula_5_6.py Show resolved Hide resolved
tests/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimate_limit_states/test_formula_5_6.py Outdated Show resolved Hide resolved
tests/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimate_limit_states/test_formula_5_6.py Outdated Show resolved Hide resolved
tests/codes/test_latex_formula.py Outdated Show resolved Hide resolved
@egarciamendez egarciamendez self-requested a review March 23, 2024 01:01
egarciamendez and others added 12 commits March 23, 2024 18:10
@egarciamendez @bro-wi
Update blueprints/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimat…
e346618 
…e_limit_states/__init__.py

Co-authored-by: Wichard Bron <[email protected]>
@egarciamendez @bro-wi
Update blueprints/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimat…
b43ba9d 
…e_limit_states/formula_5_6.py

Co-authored-by: Wichard Bron <[email protected]>
@egarciamendez @bro-wi
Update blueprints/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimat…
ed8f546 
…e_limit_states/formula_5_6.py

Co-authored-by: Wichard Bron <[email protected]>
@egarciamendez @bro-wi
Update blueprints/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimat…
570ce03 
…e_limit_states/formula_5_6.py

Co-authored-by: Wichard Bron <[email protected]>
@egarciamendez @bro-wi
Update blueprints/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimat…
e0f6d8e 
…e_limit_states/formula_5_6.py

Co-authored-by: Wichard Bron <[email protected]>
@egarciamendez @bro-wi
Update blueprints/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimat…
2070ecd 
…e_limit_states/formula_5_6.py

Co-authored-by: Wichard Bron <[email protected]>
@egarciamendez @bro-wi
Update blueprints/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimat…
e166f4f 
…e_limit_states/formula_5_6.py

Co-authored-by: Wichard Bron <[email protected]>
@egarciamendez @bro-wi
Update blueprints/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimat…
ffcb98d 
…e_limit_states/formula_5_6.py

Co-authored-by: Wichard Bron <[email protected]>
@egarciamendez @bro-wi
Update tests/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimate_lim…
04a2e1e 
…it_states/__init__.py

Co-authored-by: Wichard Bron <[email protected]>
@egarciamendez
Merge branch 'main' into 196-feature-request-add-formula-56-from-nen-…
b6d477f 
…en-1993-5

# Conflicts:
#	blueprints/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimate_limit_states/__init__.py
#	tests/codes/eurocode/nen_en_1993_5_2008/chapter_5_ultimate_limit_states/__init__.py
#	tests/codes/test_latex_formula.py
@egarciamendez
adding suggestions from review
9e99dc6
@egarciamendez
adding suggestions from review
5430ec5
egarciamendez
egarciamendez approved these changes Mar 23, 2024
View reviewed changes
Copy link
Member

@egarciamendez egarciamendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments from Wichard have been implemented. Thanks! 🚀

@egarciamendez egarciamendez merged commit 068c339 into main Mar 23, 2024
4 checks passed
@egarciamendez egarciamendez deleted the 196-feature-request-add-formula-56-from-nen-en-1993-5 branch March 23, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bro-wi bro-wi bro-wi left review comments

@egarciamendez egarciamendez egarciamendez approved these changes

@johan-tuls johan-tuls Awaiting requested review from johan-tuls

Assignees

@Klaassicking Klaassicking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[✨ Feature request]: Add formula 5.6 from NEN-EN 1993-5
3 participants
@Klaassicking @egarciamendez @bro-wi