Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(soil_type): Add SoilType class #346

Merged
merged 9 commits into from
Oct 16, 2024
Merged

feat(soil_type): Add SoilType class #346

merged 9 commits into from
Oct 16, 2024

Conversation

PabloVasconez
Copy link
Contributor

Description

Please write a description of the changes you made here.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@PabloVasconez PabloVasconez self-assigned this Sep 4, 2024
Copy link

github-actions bot commented Sep 4, 2024

Thank you so much for contributing to Blueprints! This is your Pull Request # 1 to this project.
Your contributions help thousands of engineers work more efficiently and accurately.

Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added!

@egarciamendez
Copy link
Member

egarciamendez commented Sep 8, 2024

@PabloVasconez I think a SoilType must include some extra properties that could be expected in it. Let's put this PR as a draft for now until the next meeting.
@johan-tuls Any ideas?

@egarciamendez egarciamendez marked this pull request as draft September 8, 2024 18:36
@johan-tuls
Copy link
Contributor

Soil properties do. For soil type we internally sticked to the general types that are also included here.
Only comment I might have, as they are all enums.
Is there no other option possible as enums are a finite list of options? That will be excluded now. But for what I can see it covers all I can think of

# Conflicts:
#	blueprints/materials/soil.py
@johan-tuls johan-tuls marked this pull request as ready for review October 16, 2024 08:02
@PabloVasconez PabloVasconez merged commit bf87664 into main Oct 16, 2024
4 checks passed
@PabloVasconez PabloVasconez deleted the add_nen_soil_types branch October 16, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants