Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a route GET "/version" #326

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Adding a route GET "/version" #326

merged 3 commits into from
Oct 9, 2024

Conversation

da-ekchajzer
Copy link
Collaborator

Solves #299

@demeringo
Copy link
Collaborator

@da-ekchajzer, I just added a test for non emtpy version.

I commented out the test that checks if version is valid semver... because on some releases we do not strictly use this versionning (e.g. 1.3 instead of 1.3.0).

Copy link
Collaborator

@demeringo demeringo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I just added a test. IMHO we can merge.

@da-ekchajzer da-ekchajzer merged commit 5b0194b into main Oct 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants