feat: get swap by payment hash #377
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael1011
reviewed
Jan 20, 2025
| @@ -500,6 +500,8 @@ message ClaimSwapsResponse { | |||
|
|
|||
| message GetSwapInfoRequest { | |||
| string id = 1; | |||
There was a problem hiding this comment.
This should be optional too?
There was a problem hiding this comment.
I tried to, but getting this error:
➜ boltz-client git:(feat/get-swap-by-payment-hash) ✗ make proto
Generating protosbufs
eval cd pkg/boltzrpc && ./gen_protos.sh
--grpc-gateway_out: optional field not allowed in field path: id in id
Some naming issue with our grpc gateway solution. So we cant change the without changing the name which would be breaking for our rest wrappers
pkg/boltzrpc/boltzrpc.proto
Outdated
Comment on lines
502
to
504
| string id = 1; | ||
| // only implemented for submarine swaps for now | ||
| optional bytes payment_hash = 2; |
There was a problem hiding this comment.
breaking change, unless you want to add it and deprecate the old id
jackstar12
force-pushed
the
feat/get-swap-by-payment-hash
branch
from
2683e26 to
fbac504
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo: