Skip to content
This repository has been archived by the owner on Mar 24, 2021. It is now read-only.

Add LocalResponseNorm and BatchNorm in training #15

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add LocalResponseNorm and BatchNorm in training #15

wants to merge 4 commits into from

Conversation

jatinmandav
Copy link

Addition of choice between LocalResponseNormalization and BatchNormalization.

@Borda Borda added the enhancement New feature or request label Aug 30, 2019
Borda
Borda suggested changes Aug 30, 2019
View reviewed changes
Copy link
Owner

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work and thanks for the contribution. Looking to the tests, it seems that you have not updated examples (you have added a required parameter to API but did not add it in the docstest)

yolo3/local_response_norm.py Show resolved Hide resolved
yolo3/local_response_norm.py Show resolved Hide resolved
yolo3/local_response_norm.py Outdated Show resolved Hide resolved
yolo3/local_response_norm.py Outdated Show resolved Hide resolved
yolo3/local_response_norm.py Outdated Show resolved Hide resolved
yolo3/local_response_norm.py Outdated Show resolved Hide resolved
@Borda
Copy link
Owner

Borda commented Sep 5, 2019

still missing some params in doctest, e.g

TypeError: yolo_body_tiny() missing 1 required positional argument: 'lrn'

@Borda
Copy link
Owner

Borda commented Sep 5, 2019

@jatinmandav try to run the tests in debug mode...
then it seems that the input X has some None dimensions:

b, ch, r, c = x.shape
print ((b, ch, r, c))
[out]: '(Dimension(None), Dimension(None), Dimension(None), Dimension(32))'

@Borda Borda force-pushed the master branch 2 times, most recently from 902cd4b to 4fc2405 Compare November 11, 2019 15:30
@Borda
Copy link
Owner

Borda commented Jun 2, 2020

@jatinmandav mind finish it or shall we close it?

@Borda Borda added the wontfix This will not be worked on label Jun 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Borda Borda Borda requested changes

Assignees
No one assigned
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jatinmandav @Borda