Bump version 0.72.1 #1335
Draft
Bump version 0.72.1 #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Fixes an issue with streaming for classes containing literal types.
During streaming there may not be enough tokens to satisfy a field's
literal value. In that case, the field should be `null`, and this should
be acceptable for the partial type.
The old generated `partial_types.py` does not allow the field to be null
however, so pydantic validation fails to create a
`partial_types.ClassForNullLiteral`:
```
class ClassForNullLiteral(BaseModel):
a: Literal["hi"] = None
```
The new generated `partial_types.py` after this PR allows literal fields
to be null:
```
class ClassForNullLiteral(BaseModel):
a: Optional[Literal["hi"]] = None
```
PR adds one parser test and one integ test.
<!-- ELLIPSIS_HIDDEN -->
----
> [!IMPORTANT]
> This PR allows literal fields in generated Python code to be nullable,
updating code generation and adding tests to ensure correct handling of
null literals.
>
> - **Behavior**:
> - Allows literal fields to be nullable in `partial_types.py` by
changing `a: Literal["hi"] = None` to `a: Optional[Literal["hi"]] =
None`.
> - Updates `BamlSyncClient` and `BamlAsyncClient` to handle nullable
literals in `sync_client.ts` and `async_client.ts`.
> - **Code Generation**:
> - Modifies `generate_types.rs` to wrap literals with `Optional[]`.
> - Updates `mod.rs` to reflect changes in literal handling.
> - **Testing**:
> - Adds `test_partial_class_with_null_literal` in `test_literals.rs`.
> - Introduces `literal-or-null.baml` for integration testing.
> - Adds `test_null_literal_class_hello` in `test_functions.py`.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis"
src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=BoundaryML%2Fbaml&utm_source=github&utm_medium=referral)<sup>
for 910ab4b. It will automatically
update as commits are pushed.</sup>
<!-- ELLIPSIS_HIDDEN -->
bump changelog
Bump generated code
imalsogreg
force-pushed
the
bump-version-0.72.1
branch
from
28c99cf to
8444c62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For patch release only. Do not merge.