Merge branch 'release/2.5.2'

advanced-cron-manager.php

@@ -2,7 +2,7 @@
 /**
  * Plugin Name: Advanced Cron Manager
  * Description: View, pause, remove, edit and add WP Cron events.
- * Version: 2.5.1
+ * Version: 2.5.2
  * Author: BracketSpace
  * Author URI: https://bracketspace.com
  * License: GPL3
@@ -11,7 +11,7 @@
  * @package advanced-cron-manager
  */
 
-$plugin_version = '2.5.1';
+$plugin_version = '2.5.2';
 $plugin_file    = __FILE__;
 
 /**

inc/Cron/EventsActions.php

@@ -82,7 +82,7 @@ public function insert() {
 
 		$args = array();
 
-		if ( $data['arguments'] ) {
+		if ( ! empty( $data['arguments'] ) ) {
 			foreach ( $data['arguments'] as $arg_raw ) {
 				if ( ! empty( $arg_raw ) ) {
 					$args[] = $arg_raw;
@@ -164,6 +164,13 @@ public function remove() {
 
 		// phpcs:ignore
 		$event  = $this->events->get_event_by_hash( $_REQUEST['event'] );
+
+		if ( false === $event ) {
+			$this->ajax->response( false, array(
+				__( "This event doesn't exist anymore.", 'advanced-cron-manager' ),
+			) );
+		}
+
 		$errors = array();
 
 		$this->ajax->verify_nonce( 'acm/event/remove/' . $event->hash );

readme.txt

@@ -4,7 +4,7 @@ Tags: cron, wp cron, cron jobs, manager, cron manager, crontrol
 Requires at least: 3.6
 Requires PHP: 5.3
 Tested up to: 6.3
-Stable tag: 2.5.1
+Stable tag: 2.5.2
 License: GPLv2
 License URI: http://www.gnu.org/licenses/gpl-2.0.html
 
@@ -100,6 +100,10 @@ Yes! We're offering a [custom plugin development](https://bracketspace.com/custo
 
 == Changelog ==
 
+= 2.5.2 =
+* [Fixed] Warning while adding new event.
+* [Changed] Adding a proper message when you try to delete non-existing event.
+
 = 2.5.1 =
 * [Fixed] Dynamic property notices.
 * [Fixed] Notice when adding event without arguments.