Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3545 #3546

Merged
merged 39 commits into from
Jun 30, 2024
Merged

Closes #3545 #3546

merged 39 commits into from
Jun 30, 2024

Conversation

erikdarlingdata
Copy link
Contributor

I don't know why this thing has a billion commits. Only one file is changing, to close out #3545 and aside from some whitespace weirdness, those are the only changes in this PR.

This is a hot fix. I keep running into servers where the physical reads columns are inconsistently there. I'm going to pull them for now. I don't feel like making this query dynamic at the moment.
Missing _ms in the available plans output. Not worth an issue.
Copy link
Member

@BrentOzar BrentOzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good, makes sense, merging into the dev branch. I'm doing a July release a little early to get a couple of fixes into the Consultant Toolkit, and this will be in there.

@BrentOzar BrentOzar merged commit 23e70d0 into BrentOzarULTD:dev Jun 30, 2024
3 checks passed
@BrentOzar BrentOzar added this to the 2024-08 Release milestone Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants