-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.4.1 Release #649
v1.4.1 Release #649
Conversation
* Move fume hood under exhaust fan * Update fume hood definition
* Deprecate Speed Status * Update speed mode status definition and remove speed status definition
* (no commit message provided) * Add deprecated brick locations from the 'x' file to `bricksrc/recpatches.ttl` following existing styles and properties. * remove bad module * adding rec * add submodules to checkout * small fixes * add pyproject * bump pyontoenv
I have some suggestions on REC classes to replace the Brick classes that currently don't have replacements: brick:Detention_Room -> rec:Room For the Brick location entities that don't have replacements, what are your thoughts on adding the replacement with generic rec:Room or whatever is the closest generic type? |
Also, it is difficult to tell in the PR if the following REC classes are added: rec:Lounge |
* define REC relationships * only add the BSH property shape if it is a Brick property * fix relationship definition and catch these problems with an amended test * formatting on test * fix deactivation shape * small changes to tests
…nge in recpatches.ttl
…ses in recpatches.ttl
Issues to raise with REC:
In the build tests for Brick:
|
We discovered another inconsistency in Brick v1.4.0: These 2 classes are missing subCLassOf so we don't have the parent class: We can infer based on equivalent classes. |
* feat: add deprecations for brick:TeamRoom, brick:Lobby, and brick:Lounge in recpatches.ttl * chore: remove deprecated location classes from recpatches.ttl * feat: update deprecated brick classes to their corresponding rec classes in recpatches.ttl * try to upload artifact on PR * fix if condition for v4 * only comment once * fixing the expressions. Use a variable to configure which version of python to use. cancel in-progress builds
The latest build of the Brick ontology on this PR is available here. |
Hi! I checked the generated .ttl output and the rec replacements for Brick location classes look good. I see only a few more issues: 1.There are still missing REC classes: rec:Lounge For each I'm expecting to see: rec: a rdfs:Class,
brick:Ablutions_Room -> rec:Room
brick:Vertical_Space -> rec:ElevatorShaft & change to rec:Room? Thanks! |
…ls Storage, and Vertical Space
The latest build of the Brick ontology on this PR is available here. |
The latest build of the Brick ontology on this PR is available here. |
PR gathering the changes for Brick v1.4.1