Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.4.1 Release #649

Merged
merged 11 commits into from
Aug 22, 2024
Merged

v1.4.1 Release #649

merged 11 commits into from
Aug 22, 2024

Conversation

gtfierro
Copy link
Member

@gtfierro gtfierro commented Aug 6, 2024

PR gathering the changes for Brick v1.4.1

gtfierro and others added 4 commits August 6, 2024 14:55
* Move fume hood under exhaust fan

* Update fume hood definition
* Deprecate Speed Status

* Update speed mode status definition and remove speed status definition
* (no commit message provided)

* Add deprecated brick locations from the 'x' file to `bricksrc/recpatches.ttl` following existing styles and properties.

* remove bad module

* adding rec

* add submodules to checkout

* small fixes

* add pyproject

* bump pyontoenv
@sarahmacSE978
Copy link

sarahmacSE978 commented Aug 8, 2024

I have some suggestions on REC classes to replace the Brick classes that currently don't have replacements:

brick:Detention_Room -> rec:Room
brick:Environment_Box -> rec:Laboratory
brick:Field_Of_Play -> rec:OutdoorSpace
brick:First_Aid_Room -> rec:TreatmentRoom
brick:Freezer -> rec:Room
brick:Gatehouse -> rec:Building
brick:Hospitality_Box -> rec:Room
brick:Hot_Box -> rec:Room
brick:Information_Area -> rec:Reception
brick:Lighting_Zone -> rec:Zone
brick:Loading_Dock -> rec:LoadingReceivingRoom
brick:Majlis-> rec:Lounge
brick:Media_Room -> rec:RecordingRoom
brick:Media_Hot_Desk -> rec:RecordingRoom
brick:Media_Production_Room -> rec:RecordingRoom
brick:Outside -> rec:OutdoorSpace
brick:Parking_Level -> rec:Level
brick:Parking_Structure -> rec:Building
brick:Prayer_Room -> rec:MeditationRoom
brick:Pump_Room -> rec:UtilitiesRoom
brick:Riser -> rec:Room
brick:Sports_Service_Room -> rec:ExerciseRoom
brick:Stage_Riser -> rec:Room
brick:TETRA_Room -> rec:TelecommunicationRoom
brick:Ticketing_Booth -> rec:Building
brick:Tunnel -> rec:Room
brick:Water_Tank -> rec:UtilitiesRoom
brick:Vertical_Space -> rec:ElevatorShaft

For the Brick location entities that don't have replacements, what are your thoughts on adding the replacement with generic rec:Room or whatever is the closest generic type?

@sarahmacSE978
Copy link

Also, it is difficult to tell in the PR if the following REC classes are added:

rec:Lounge
rec:Teamroom
rec:Lobby

* define REC relationships

* only add the BSH property shape if it is a Brick property

* fix relationship definition and catch these problems with an amended test

* formatting on test

* fix deactivation shape

* small changes to tests
@gtfierro
Copy link
Member Author

gtfierro commented Aug 8, 2024

Issues to raise with REC:

  • missing classes in the .ttl release like rec:Lounge. This appears in their online docs, but isn't in the .ttl file . Can these be updated?
  • some classes we really want to keep: Parking Level, Lighting Zone, others?
  • mappings from Brick to REC should be 1:1 where possible, or they might move to something more generic. The Brick to REC replacement should not get more specific

In the build tests for Brick:

  • raise an error if there are any objects of brick:isReplacedby that are not properly defined
  • make brick:isReplacedBy required for all deprecations?

@sarahmacSE978
Copy link

We discovered another inconsistency in Brick v1.4.0:

These 2 classes are missing subCLassOf so we don't have the parent class:
brick:EV_Charging_Hub
brick:Horizontal_Fan_Coil_Unit

We can infer based on equivalent classes.

* feat: add deprecations for brick:TeamRoom, brick:Lobby, and brick:Lounge in recpatches.ttl

* chore: remove deprecated location classes from recpatches.ttl

* feat: update deprecated brick classes to their corresponding rec classes in recpatches.ttl

* try to upload artifact on PR

* fix if condition for v4

* only comment once

* fixing the expressions. Use a variable to configure which version of python to use. cancel in-progress builds
Copy link

The latest build of the Brick ontology on this PR is available here.

@sarahmacSE978
Copy link

Hi! I checked the generated .ttl output and the rec replacements for Brick location classes look good. I see only a few more issues:

1.There are still missing REC classes:

rec:Lounge
rec:Teamroom
rec:Lobby

For each I'm expecting to see:

rec: a rdfs:Class,
sh:NodeShape ;
rdfs:label ""^^xsd:string ;
rdfs:subClassOf rec:Room .

  1. I've identified a few more brick location classes that are missing REC replacements:

brick:Ablutions_Room -> rec:Room
brick:Hazardous_Materials_Storage -> rec:Storage

  1. You mentioned in a previous meeting that you didn't think rec:ElevatorShaft was a good equivalent to brick:Vertical_Space, do you want to replace rec:Room instead?

brick:Vertical_Space -> rec:ElevatorShaft & change to rec:Room?

Thanks!

Copy link

The latest build of the Brick ontology on this PR is available here.

Copy link

The latest build of the Brick ontology on this PR is available here.

@gtfierro gtfierro merged commit 859a744 into master Aug 22, 2024
4 checks passed
@gtfierro gtfierro deleted the v1.4.1 branch August 22, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants