Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part of #22: Create ADS1115 skeleton class #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Part of #22: Create ADS1115 skeleton class #40

wants to merge 2 commits into from

Conversation

kevinl120
Copy link
Contributor

@kevinl120 kevinl120 commented Dec 7, 2020 •
edited
Loading

Overview

  1. This PR fixes part of Create software skeleton classes for sensors #22.
  2. This PR does the following: Creates skeleton for ADS1115 class.

harrisonCassar
harrisonCassar requested changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@harrisonCassar harrisonCassar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A minor thing to respect some recent interface changes made. Fixing the merge conflicts will also, likely, fix these.

Software/spartan/src/sensors/ads1115.cpp Outdated

int spartan::ADS1115::powerOff() { return 0; }

int spartan::ADS1115::poll(MasterDataPacket &dp) { return 0; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be renamed to pollData, as this is the new interface for the Sensor abstract base class. See #48 for details.

Software/spartan/src/sensors/ads1115.h Outdated

virtual int powerOn();
virtual int powerOff();
virtual int poll(MasterDataPacket &dp);
Copy link
Contributor

@harrisonCassar harrisonCassar Jan 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment^ (rename to pollData).

@kevinl120 kevinl120 mentioned this pull request Jan 13, 2021
Closed
@harrisonCassar harrisonCassar mentioned this pull request Jan 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrisonCassar harrisonCassar harrisonCassar requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinl120 @harrisonCassar