Fix part of #17: Add Github Actions for CI #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrisonCassar
approved these changes
Jan 11, 2021
There was a problem hiding this comment.
Looks great! I'll merge this here in just a bit...
Though I'm sure you might have already seen, for documentation's sake, I'll just mention that I also included on the master README a method I was thinking of for implementing a system test infrastructure that makes it easy for Reach developers to add new ones. Just thought I'd mention it here since its a bit relevant!
Comment on lines
+42
to
+48
| # - name: Test | ||
| # # Currently, we have no tests. Once tests are added, we can uncomment this build step. | ||
| # working-directory: ${{runner.workspace}}/Software/build | ||
| # shell: bash | ||
| # # Execute tests defined by the CMake configuration. | ||
| # See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail | ||
| # run: ctest -C $BUILD_TYPE |
There was a problem hiding this comment.
Thanks for including this section for running ctest (for unit tests) once we get there. We'll want to add some documentation possibly in the master README, but I think at this point, though, we can wait until we actually add some unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes part of #17.
This PR does the following: Creates build configuration file to use with Github Actions. Builds are triggered on each pull request.