Added member status to the home page #24
Conversation
|
@Lukman-01 is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for the PR, @Lukman-01! First, let's make the PR description even nicer. I love your use of screenshot to show the implementation. Could you add a couple more screenshots for the other possible states?
Could you also update your PR description to link to issue #5 ? Not only is that useful context, it also makes it so that when this PR gets merged the matching issue is automatically closed as well. |
|
Thank you @derrekcoleman for the observation. Instead of doing screenshot for each implementation, I made a short clip demostrating each implementation. I hope it covers every implementation needed. https://www.loom.com/share/4e7125956a8f481ebef43f1847e5d119?sid=466dfe05-23a5-4283-a8b8-e3498dad428c kindly check the above link for the demostration. |
|
Good morning Sir @derrekcoleman, kindly review if there will be any changes I need to make. |
…l.com into 5-Connected-Wallet-Info
…1/batch10.buidlguidl.com into 5-Connected-Wallet-Info
|
Good day @derrekcoleman, @phipsae, I have Implemented all cases required for the membership status.
As for the last one(if a member but have not checkedIn), together with afformentioned ones above are demostrated in the clip below https://www.loom.com/share/996b3e853d9b46e2ac2814569bdacc5c?sid=4dea6659-620b-482f-b18d-36a1a718852a |
packages/nextjs/app/page.tsx
Outdated
| connectedAddress: string; | ||
| isAllowListed: boolean; | ||
| isCheckedIn: boolean; | ||
| userContractAddress: string; |
There was a problem hiding this comment.
Do we need userContractAddress or is connectedAddress enough?
packages/nextjs/app/page.tsx
Outdated
| </CardHeader> | ||
| <CardContent> | ||
| <p className="text-sm opacity-70"> | ||
| Active with contract: {userContractAddress?.slice(0, 6)}...{userContractAddress?.slice(-4)} |
There was a problem hiding this comment.
Here you might want to use the SE2 component <Address>
|
Thank you Sir @phipsae, corrections implemented. |
packages/nextjs/app/page.tsx
Outdated
| <p className="text-sm opacity-70"> | ||
| Active with wallet address: <Address address={connectedAddress} /> | ||
| </p> |
There was a problem hiding this comment.
There’s a hydration error occurring. Please make sure to always check your console for any potential errors.
|
@phipsae Thank you very much Sir, I will be more observant of the console now. The issue has been resolved.
|
|
Perfect, thanks for your work! Let's merge. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Description
I added batch member status and if checked in status to the home page
Your ENS/address: 0x186a761645f2A264ad0A655Fb632Ca99150803A9