Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(schema): add deprecation warning for Delivery Capacity #258

Merged
merged 1 commit into from
Oct 21, 2020
Merged

docs(schema): add deprecation warning for Delivery Capacity #258

merged 1 commit into from
Oct 21, 2020

Conversation

macintoshpie
Copy link
Contributor

Per discussion here BuildingSync/TestSuite#37 (comment)

It doesn't make sense to have Delivery capacity when the linked systems (fan, heating, cooling) have capacities of their own.

@macintoshpie macintoshpie mentioned this pull request Oct 21, 2020
Closed
markborkum
markborkum reviewed Oct 21, 2020
View reviewed changes
Copy link
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the deprecation warning include a version, e.g., "This element is being deprecated in version X.Y.Z, use ..."?

markborkum
markborkum approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecation policy discussed during weekly standup meeting. To be added in new PR.

Changes in PR are approved.

@markborkum
Copy link
Contributor

New PR to add deprecation policy: #261

@macintoshpie macintoshpie merged commit be3587f into develop Oct 21, 2020
@macintoshpie macintoshpie deleted the docs/delivery-capacity branch October 21, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markborkum markborkum markborkum approved these changes

@nllong nllong Awaiting requested review from nllong

@corymosiman12 corymosiman12 Awaiting requested review from corymosiman12

Assignees
No one assigned
Labels
Non-breaking Change Schema: Systems Update to systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macintoshpie @markborkum