Skip to content

Commit

Permalink
chore: polishing
Browse files Browse the repository at this point in the history
  • Loading branch information
@martinalbert
martinalbert committed May 5, 2024
1 parent 3bd9f2d commit e989622
Show file tree
Hide file tree
Showing 3 changed files with 43 additions and 32 deletions.
28 changes: 15 additions & 13 deletions butter_cms/tests/test_author.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
from butter_cms.author import Author
from butter_cms.tests.mocks.author_mocks import list_authors, list_authors_with_posts, get_author, get_author_with_posts


class TestListAuthor(unittest.TestCase):
@patch('butter_cms.author.Author.all')
def test_all(self, mock_all):
Expand All @@ -13,11 +12,13 @@ def test_all(self, mock_all):

self.assertIsNotNone(response)
self.assertIn('data', response)
self.assertIsNotNone(response['data'])
self.assertIsInstance(response['data'], list)
self.assertGreater(len(response['data']), 0)

author_data = response['data'][0]
data = response['data']
self.assertIsNotNone(data)
self.assertIsInstance(data, list)
self.assertGreater(len(data), 0)

author_data = data[0]
self.assertEqual('John', author_data.get('first_name'))
self.assertIsNone(author_data.get('recent_posts'))

Expand All @@ -29,16 +30,17 @@ def test_all_include_recent_posts(self, mock_all):

self.assertIsNotNone(response)
self.assertIn('data', response)
self.assertIsNotNone(response['data'])
self.assertIsInstance(response['data'], list)
self.assertGreater(len(response['data']), 0)

author_data = response['data'][0]
data = response['data']
self.assertIsNotNone(data)
self.assertIsInstance(data, list)
self.assertGreater(len(data), 0)

author_data = data[0]
self.assertEqual('John', author_data.get('first_name'))
self.assertIn('recent_posts', author_data)
self.assertGreater(len(author_data['recent_posts']), 0)


class TestRetrieveAuthor(unittest.TestCase):
@patch('butter_cms.author.Author.get')
def test_get(self, mock_get):
Expand All @@ -48,23 +50,23 @@ def test_get(self, mock_get):

self.assertIsNotNone(response)
self.assertIn('data', response)
self.assertIsNotNone(response['data'])

author_data = response['data']
self.assertIsNotNone(author_data)
self.assertEqual('John', author_data.get('first_name'))
self.assertIsNone(author_data.get('recent_posts'))

@patch('butter_cms.author.Author.get')
def test_get_include_recent_posts(self, mock_get):
mock_get.return_value = get_author_with_posts() # Assuming it returns the first author with posts
mock_get.return_value = get_author_with_posts()
author = Author('<demo-token>')
response = author.get('john-doe', params={'include': 'recent_posts'})

self.assertIsNotNone(response)
self.assertIn('data', response)
self.assertIsNotNone(response['data'])

author_data = response['data']
self.assertIsNotNone(author_data)
self.assertEqual('John', author_data.get('first_name'))
self.assertIn('recent_posts', author_data)
self.assertGreater(len(author_data['recent_posts']), 0)
Expand Down
25 changes: 14 additions & 11 deletions butter_cms/tests/test_category.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,13 @@ def test_all(self, mock_all):

self.assertIsNotNone(response)
self.assertIn('data', response)
self.assertIsNotNone(response['data'])
self.assertIsInstance(response['data'], list)
self.assertGreater(len(response['data']), 0)

category_data = response['data'][0]
data = response['data']
self.assertIsNotNone(data)
self.assertIsInstance(data, list)
self.assertGreater(len(data), 0)

category_data = data[0]
self.assertEqual('Category 1', category_data.get('name'))
self.assertIsNone(category_data.get('recent_posts'))

Expand All @@ -29,11 +31,13 @@ def test_all_include_recent_posts(self, mock_all):

self.assertIsNotNone(response)
self.assertIn('data', response)
self.assertIsNotNone(response['data'])
self.assertIsInstance(response['data'], list)
self.assertGreater(len(response['data']), 0)

category_data = response['data'][0]
data = response['data']
self.assertIsNotNone(data)
self.assertIsInstance(data, list)
self.assertGreater(len(data), 0)

category_data = data[0]
self.assertEqual('Category 1', category_data.get('name'))
self.assertIn('recent_posts', category_data)
self.assertGreater(len(category_data['recent_posts']), 0)
Expand All @@ -47,9 +51,9 @@ def test_get(self, mock_get):

self.assertIsNotNone(response)
self.assertIn('data', response)
self.assertIsNotNone(response['data'])

category_data = response['data']
self.assertIsNotNone(category_data)
self.assertEqual('Category 1', category_data.get('name'))
self.assertIsNone(category_data.get('recent_posts'))

Expand All @@ -61,10 +65,9 @@ def test_get_include_recent_posts(self, mock_get):

self.assertIsNotNone(response)
self.assertIn('data', response)
self.assertIsNotNone(response['data'])
self.assertIsInstance(response['data'], dict)

category_data = response['data']
self.assertIsNotNone(category_data)
self.assertEqual('Category 1', category_data.get('name'))
self.assertIn('recent_posts', category_data)
self.assertGreater(len(category_data['recent_posts']), 0)
22 changes: 14 additions & 8 deletions butter_cms/tests/test_content_field.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,15 @@ def test_list_filtered_content_fields(self, mock_get):
self.assertIn('data', response)

data = response['data']
self.assertIsNotNone(data)
self.assertIn('key1', data)
self.assertIn('key2', data)

k1 = data['key1']
self.assertEqual(2, len(k1))
self.assertIn('meta', k1[0])
self.assertIn('id', k1[0]['meta'])

self.assertIn('key2', data)

k2 = data['key2']
self.assertEqual(1, len(k2))
self.assertIn('meta', k2[0])
Expand All @@ -54,10 +56,12 @@ def test_get_content_field_without_filtering(self, mock_get):

self.assertIsNotNone(response)
self.assertIn('data', response)
self.assertIsNotNone(response['data'])
self.assertIn('field', response['data'])

f = response['data']['field']
data = response['data']
self.assertIsNotNone(data)
self.assertIn('field', data)

f = data['field']
self.assertEqual(2, len(f))
self.assertIn('meta', f[0])
self.assertIn('id', f[0]['meta'])
Expand All @@ -70,10 +74,12 @@ def test_get_filtered_content_field(self, mock_get):

self.assertIsNotNone(response)
self.assertIn('data', response)
self.assertIsNotNone(response['data'])
self.assertIn('field', response['data'])

f = response['data']['field']
data = response['data']
self.assertIsNotNone(data)
self.assertIn('field', data)

f = data['field']
self.assertEqual(1, len(f))
self.assertIn('meta', f[0])
self.assertIn('id', f[0]['meta'])
Expand Down

0 comments on commit e989622

Please sign in to comment.