code optimize

[Roxannej]

No description provided.

[gosuwachu]

Suggested change

	use SortMode::*;
	use SortMode as E;

[gosuwachu]

This unfortunately is not recommended because it throws away some of the safety features of enums inside match expressions. See: https://www.youtube.com/watch?v=8j_FbjiowvE

Suggested change

	SizeAscending => "size ascending",
	SizeDescending => "size descending",
	MTimeAscending => "modified ascending",
	MTimeDescending => "modified descending",
	CountAscending => "items ascending",
	CountDescending => "items descending",
	E::SizeAscending => "size ascending",
	E::SizeDescending => "size descending",
	E::MTimeAscending => "modified ascending",
	E::MTimeDescending => "modified descending",
	E::CountAscending => "items ascending",
	E::CountDescending => "items descending",

[Byron]

Thanks for this hint! I wasn't really seeing it this way just yet, but totally see the point (i.e. as enums are changing their variant names, there is then catch-all variants that show up as warnings for 'unused variables').

[Byron]

I don't perceive this as optimization, but that might just be an issue with the wording.

However, I don't think shortening lines is important enough to merge this PR, after all, the look doesn't change.

Thanks for your understanding.

[Byron]

Thanks for this hint! I wasn't really seeing it this way just yet, but totally see the point (i.e. as enums are changing their variant names, there is then catch-all variants that show up as warnings for 'unused variables').