Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some pre-commit errors #123

Merged
merged 15 commits into from
May 30, 2024
Merged

Fix some pre-commit errors #123

merged 15 commits into from
May 30, 2024

Conversation

jdeschamps
Copy link
Member

@jdeschamps jdeschamps commented May 27, 2024

Description

Fix ruff and some mypy errors.

Notes:

  • NDFlip has been renamed XYFlip since it is not flipping z since an earlier PR

Please ensure your PR meets the following requirements:

  • Code builds and passes tests locally, including doctests
  • New tests have been added (for bug fixes/features)
  • Pre-commit passes
  • PR to the documentation exists (for bug fixes / features)

@jdeschamps jdeschamps changed the title Jd/chore/pre commit Fix some pre-commit errors May 27, 2024
@jdeschamps jdeschamps mentioned this pull request May 28, 2024
4 tasks
@jdeschamps jdeschamps requested review from CatEek and melisande-c May 28, 2024 13:07
@jdeschamps
Copy link
Member Author

Once this PR and #124 are merged, we should be down to just a handful of docstring and mypy errors which will be the subject of a different PR as they relate to different refactoring.

Copy link
Member

@melisande-c melisande-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@CatEek
Copy link
Contributor

CatEek commented May 30, 2024

supported_extraction_strategies.py was removed, why? Sorry if i'm missing something

@jdeschamps
Copy link
Member Author

supported_extraction_strategies.py was removed, why? Sorry if i'm missing something

It was unused!

@jdeschamps jdeschamps merged commit 99d04c4 into main May 30, 2024
12 of 15 checks passed
@jdeschamps jdeschamps deleted the jd/chore/pre-commit branch May 30, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants