-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor prediction pipeline #131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
+ Coverage 81.90% 91.33% +9.42%
==========================================
Files 103 104 +1
Lines 2841 2561 -280
==========================================
+ Hits 2327 2339 +12
+ Misses 514 222 -292 ☔ View full report in Codecov by Sentry. |
CatEek
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When not tiling prediction, the images are forced through the tiling pipeline (with a
TileInformation
class being passed along the images), and it makes the debugging complex. This PR splits the prediction datasets into tiled and not-tiled.I also changed the
total
memory intoavailable
for the switch between in memory and iterable datasets during training, as it better represents what can be loaded in memory.Finally, I simplified the stitching and prediction pipeline by passing the
TileInformation
further.Changes Made
get_ram_size
now looks at available memory.sort
in datasets,is_tile
inTilingInformation
.Related issues
This PR fixes #125.
Notes
This PR will create merge issues with #134.
Currently, there are two issues remaining:
extract_tile
returns C(Z)YX, while the non tiling datasets always return SC(Z)YX with a singleton dimensionTensors
intonp.ndarray
. I tried to make it happen in the same place (in the prediction loop), but that is not entirely solved.Please ensure your PR meets the following requirements: