Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow Noise2Noise with different in and out channels #152

Merged
merged 6 commits into from
Jun 21, 2024

Conversation

jdeschamps
Copy link
Member

@jdeschamps jdeschamps commented Jun 18, 2024

Description

Until now, Noise2Noise was only possible with the same number of input and output channels. But one can envision have multiple channels in (e.g. time frames) and supervising with a single frame.

This PR relaxes the constraints on Noise2Noise: channels in and out can now be different, and UNet is not mandatory!

  • What: Remove algorithm_model constraint on N2N, and change the configuration convenience function.
  • Why: We might try to run Noise2Noise with different in and out channels.
  • How: See what.

Changes Made

  • Modified: algorithm_model and create_n2n_configuration, and the corresponding tests.

Please ensure your PR meets the following requirements:

@jdeschamps
Copy link
Member Author

Requires #149 to be merged for tests to pass.

@jdeschamps jdeschamps changed the title Allow Noise2Noise with different in and out channels (feat) Allow Noise2Noise with different in and out channels Jun 18, 2024
@jdeschamps jdeschamps changed the title (feat) Allow Noise2Noise with different in and out channels Feature: Allow Noise2Noise with different in and out channels Jun 18, 2024
@jdeschamps jdeschamps requested review from CatEek and melisande-c June 19, 2024 13:32
@jdeschamps jdeschamps merged commit 9edcd15 into main Jun 21, 2024
15 checks passed
@jdeschamps jdeschamps deleted the jd/feat/n2n_different_in_out_channels branch June 21, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants