Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Use current weights for prediction #166

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

jdeschamps
Copy link
Member

Description

Currently, we pass both model and checkpoint to trainer.predict. My understanding of the docs is that checkpoint takes precedence.

It is not clear what model is the best to use (last vs best), especially in the context of Noise2Void. In order to avoid a behaviour that has not be clarified and described, this PR removes the checkpoint parameter altogether.

In the future, we might want to revisit that. Currently, we would advocate letting users configure the checkpoint callback and then load the correct weights themselves.

  • What: Remove checkpoint parameter from careamist.predict.
  • Why: Clarify which weights are used (in this case, the current ones).
  • How: Remove the parameter from the predict function signature, and from the call to the trainer.

Changes Made

  • Modified: careamist.py.

Please ensure your PR meets the following requirements:

  • Code builds and passes tests locally, including doctests
  • New tests have been added (for bug fixes/features)
  • Pre-commit passes
  • PR to the documentation exists (for bug fixes / features)

@jdeschamps jdeschamps requested review from CatEek and melisande-c June 24, 2024 14:51
@jdeschamps jdeschamps merged commit da187e7 into main Jul 3, 2024
15 checks passed
@jdeschamps jdeschamps deleted the jd/refac/remove_unused_checkpoint branch July 3, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants