Feature: Use current weights for prediction #166
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we pass both
model
andcheckpoint
totrainer.predict
. My understanding of the docs is thatcheckpoint
takes precedence.It is not clear what model is the best to use (
last
vsbest
), especially in the context of Noise2Void. In order to avoid a behaviour that has not be clarified and described, this PR removes thecheckpoint
parameter altogether.In the future, we might want to revisit that. Currently, we would advocate letting users configure the checkpoint callback and then load the correct weights themselves.
checkpoint
parameter fromcareamist.predict
.predict
function signature, and from the call to thetrainer
.Changes Made
careamist.py
.Please ensure your PR meets the following requirements: