Fix: prevent noise model from moving to CPU #359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veegalinova
force-pushed
the
vg/fix/noise-model-device
branch
from
1f2172d to
8f03c88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where the noise model was unintentionally moved to the CPU before training, and thus did not train on GPU.
_set_model_modewas called, the model was moved to the CPU by default, which caused training to happen on the CPU instead of the GPU.Changes Made
_set_model_mode, moved final move to CPU to the end of thefitfunction.Please ensure your PR meets the following requirements: