don't cache based on token if token doesn't determine the successful response #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed for cases where the token doesn't affect the result in a successful case (some tokens may return different results if they are missing permissions but those won't be cached)
chrisj
force-pushed
the
cj_improve_cache
branch
from
64328ed to
9b747f6
Compare
|
because the service token is used for these function calls, this pull request shouldn't make a difference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated cachetools usage to no longer cache based on the token supplied for cases where the token doesn't affect the result in a successful case (some tokens may return different results if they are missing permissions but those won't be cached)