Allow openstack esi node list to filter based on resource_class, owner, and lessee #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzumainn
requested changes
May 14, 2024
tzumainn
requested changes
May 15, 2024
skanthed
force-pushed
the
apply-filter
branch
2 times, most recently
from
23a3db9 to
c2ac65a
Compare
|
@tzumainn updated the code with the changes. |
tzumainn
requested changes
May 15, 2024
|
@tzumainn I attempted to address the issue locally after installing the ironic-client, but encountered some problems. I will try again if necessary. |
|
@tzumainn I tested the script with ironic-client it's working fine. |
tzumainn
requested changes
May 17, 2024
|
@tzumainn Once the code looks good, I will add the unit-test. |
skanthed
force-pushed
the
apply-filter
branch
4 times, most recently
from
0d5f7e9 to
09debe6
Compare
|
Can you rebase this commit to make it a single commit (and get rid of the merge commit)? |
tzumainn
reviewed
May 22, 2024
|
|
||
| @mock.patch('esi_leap.common.ironic.get_node_list') | ||
| @mock.patch('esi_leap.common.keystone.get_project_list') | ||
| def test_get_resource_class_filter(self, mock_gpl, mock_gnl): |
There was a problem hiding this comment.
Can you rename this to test_get_all_resource_class_filter?
There was a problem hiding this comment.
Sure I will do this.
|
Yep - you want to squash your commits:
https://stackoverflow.com/questions/5189560/how-do-i-squash-my-last-n-commits-together
…On Wed, May 22, 2024 at 9:56 AM Surbhi Kanthed ***@***.***> wrote:
@tzumainn <https://github.com/tzumainn> while merging can you combine
commits into one and merge?
—
Reply to this email directly, view it on GitHub
<#155 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJYRMRE5IEU4XCEEUKOW73ZDSPZ5AVCNFSM6AAAAABHWEXB5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRUHA3DKOBUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
skanthed
force-pushed
the
apply-filter
branch
2 times, most recently
from
bb6480b to
a9349f9
Compare
|
Due to merge conflict closing this and addressing it in #156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.