Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DRAFT) Post-processing for H models #287

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

Conversation

damonbayer
Copy link
Collaborator

@damonbayer damonbayer commented Jan 8, 2025

Unfortunately, this has become a bit of monster PR, but it will result in a lot more consistency, clarity, and adaptability in the project.

  • Improves formatting of data files - no longer uses confusing names like "Disease" and "Other", instead uses more descriptive names like "observed_ed_visits" and "other_ed_visits" in a tidy format.
  • Removes generation of legacy-formatted data files.
  • Simplifies and improves output of timeseries models to more closely match PyRenew models
  • Introduces group_time_index_to_date for robust PyRenew-index to date conversions.
  • Introduces parse_pyrenew_model_name to extract expected features (h, e, w), based on the model's name,
  • Generalizes post-processing to work with models featuring any combination of h and e.
  • Simplifies post-processing to remove redundant data generation.
  • Updates all parts of pipeline to work with the new formatted data files

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 8.19%. Comparing base (1c2e2cc) to head (e6dcb00).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pipelines/prep_data.py 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1c2e2cc) and HEAD (e6dcb00). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1c2e2cc) HEAD (e6dcb00)
hewr 1 0
Additional details and impacted files
@@            Coverage Diff            @@
##             main    #287      +/-   ##
=========================================
- Coverage   15.87%   8.19%   -7.69%     
=========================================
  Files          21      15       -6     
  Lines        1537    1074     -463     
=========================================
- Hits          244      88     -156     
+ Misses       1293     986     -307     
Flag Coverage Δ
hewr ?
pipelines 0.00% <0.00%> (ø)
pyrenew_hew 19.25% <ø> (+17.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant