Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing args to to_forecast_data, code review suggestions #366

Closed
wants to merge 6 commits into from

Conversation

sbidari
Copy link
Collaborator

@sbidari sbidari commented Feb 28, 2025

No description provided.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.47%. Comparing base (abfdffb) to head (9da7a9d).
Report is 1 commits behind head on sb-update-end-to-end-test.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           sb-update-end-to-end-test     #366      +/-   ##
=============================================================
+ Coverage                      30.45%   30.47%   +0.02%     
=============================================================
  Files                             26       26              
  Lines                           1937     1939       +2     
=============================================================
+ Hits                             590      591       +1     
- Misses                          1347     1348       +1     
Flag Coverage Δ
hewr 35.35% <ø> (ø)
pipelines 14.41% <ø> (ø)
pyrenew_hew 42.02% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbidari
Copy link
Collaborator Author

sbidari commented Feb 28, 2025

Accidently committed to a wrong branch

@sbidari sbidari closed this Feb 28, 2025
@sbidari sbidari deleted the dhm-pop-calc-suggestion branch February 28, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants