Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road Conditions Translator #22

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Road Conditions Translator #22

wants to merge 17 commits into from

Conversation

mwodahl
Copy link
Contributor

@mwodahl mwodahl commented Dec 12, 2024

This PR adds a Road Conditions translator that scrapes the CDOT Road Conditions endpoint and pushes the appropriate TIMs to the TIM Manager. The translator will submit an all-clear TIM in the event that the TIM for a road segment doesn't have any ITIS codes. This translator has been tested locally with the TIM Manager and unit tests were verified to run correctly with these changes.

Copy link
Member

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, I just had some suggestions & one blocking comment.

Translators/RoadConditions/Dockerfile Outdated Show resolved Hide resolved
Translators/RoadConditions/README.md Outdated Show resolved Hide resolved
Translators/RoadConditions/main.py Outdated Show resolved Hide resolved
Translators/RoadConditions/main.py Outdated Show resolved Hide resolved
Copy link
Contributor

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions

Translators/RoadConditions/itis_codes.py Show resolved Hide resolved
Translators/RoadConditions/main.py Outdated Show resolved Hide resolved
Translators/RoadConditions/main.py Outdated Show resolved Hide resolved
Translators/RoadConditions/pgquery.py Show resolved Hide resolved
tests/Translators/RoadConditions/test_tim_generator.py Outdated Show resolved Hide resolved
Translators/RoadConditions/tim_translator.py Outdated Show resolved Hide resolved
Copy link
Member

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good & the unit tests pass!

Copy link
Member

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The introduction of the RCFeature class significantly improves code readability—excellent work!

logging.info(f"TIM already active for record: {tim_body['clientId']}")
continue
tims["timRcList"].append(tim_body)
print(tims)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's cleanup the print statement

Copy link
Contributor

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment about print line

Copy link
Member

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good & the unit tests pass!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants