Fix/keycloak timeout #445
Open
Fix/keycloak timeout #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msm-cert
reviewed
Feb 4, 2025
Comment on lines
+5
to
6
|
|
||
| import uvicorn # type: ignore |
There was a problem hiding this comment.
Suggested change
| import uvicorn # type: ignore | |
| import uvicorn # type: ignore |
| "client_id": db.config.openid_client_id, | ||
| "client_secret": db.config.openid_secret, | ||
| } | ||
| url = "http://mquery-keycloak-1:8080/auth/realms/myrealm/protocol/openid-connect/token" |
There was a problem hiding this comment.
Shouldn't be hardcoded - use url from config instead
| @@ -70,6 +74,24 @@ def with_plugins() -> Iterable[PluginManager]: | |||
| plugins.cleanup() | |||
|
|
|||
|
|
|||
| def get_new_tokens(refresh_token): | |||
There was a problem hiding this comment.
Please add typing (I guess get_new_tokens(refresh_token: str) -> Tuple[str, str], but recheck)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
What is the current behaviour?
Currently mquery does not revoke token by itself therefore forcing relogin.
Also after token expiration user is forced to log in even if instance allows anonymous access,
What is the new behaviour?
Test plan
Token is auto-refreshing itself now.
Also when the token expires, user get anonymous access.
Also User is not logged out so often.
Closing issues
fixes #411
fixes #425