Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDC documentation for non uniform heat equation #441

Merged
merged 28 commits into from
Jun 24, 2024

Conversation

thierryantoun
Copy link
Member

This PR aims to write the Heat equation example with non-uniform space discretization.
I still have issues with boundary conditions, might be the ghost points initialization.

@thierryantoun thierryantoun marked this pull request as draft May 13, 2024 08:53
@thierryantoun thierryantoun marked this pull request as ready for review June 10, 2024 08:02
@thierryantoun thierryantoun requested a review from tpadioleau June 10, 2024 08:03
@tpadioleau
Copy link
Member

Can you resolve the conflicts and put it out of draft if a review is needed ?

@tpadioleau
Copy link
Member

@thierryantoun can you have a look at the conflicts ? Back to draft in the meantime.

@tpadioleau tpadioleau marked this pull request as draft June 12, 2024 17:17
@tpadioleau
Copy link
Member

tpadioleau commented Jun 21, 2024

@thierryantoun Can you fix the branch to pass the CI ?

@thierryantoun thierryantoun marked this pull request as ready for review June 24, 2024 12:02
@thierryantoun thierryantoun mentioned this pull request Jun 24, 2024
4 tasks
@tpadioleau tpadioleau merged commit d1b5167 into main Jun 24, 2024
3 checks passed
@tpadioleau tpadioleau deleted the ddc/documentation/non_uniform_heat_equation branch June 24, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants